Added option random_cb for images in edit fields#930
Open
niahoo wants to merge 1 commit intoFrozenNode:devfrom
Open
Added option random_cb for images in edit fields#930niahoo wants to merge 1 commit intoFrozenNode:devfrom
niahoo wants to merge 1 commit intoFrozenNode:devfrom
Conversation
…to provide a callback to generate the random name.
Author
|
Hi, could you tell me if you're interested or not ? |
Contributor
|
@niahoo I'm interested just trying to decide the full need v/s if this is the best way. |
Author
|
The full need is to be able to specify the file name with a function. The best thing to do imho is to allow a function as a value for the I can code that if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is a small addition to let the developer generate image names.
I wanted to add a
functionpossible value to thenamingoption and add anaming_cboption, but this requires some refactoring to keep the code clean*.So, this just adds the possibility to provide a callback, but it is of-course not mandatory for the callback to provide actual-random names. (md5 of the file content is what I personnally do !).
Also if you like this and would rather set the defaults-options/rules in the
Field\Fileclass, just tell me.(* I wish that
Multupdoes not generate names by itself, only using the callbacks it's given or a name (string) it's given.)